MidgardVTT-Entwicklung
/
foundry-vtt-system-midgard5
7
0
Fork 0
Code Issues 16 Pull Requests Actions Projects 1 Releases 8 Wiki Activity

#18 Remove ContainerId from containers #29

Merged
Byroks merged 1 commits from #18-remove-unnecessary-containerId into develop 2024-01-15 14:15:32 +01:00
Conversation 0 Commits 1 Files Changed 1 +20 -23
Byroks commented 2024-01-08 12:11:45 +01:00
Owner
Copy Link

Changes

  • remove containerId variable from containers as it's not needed
Changes + remove containerId variable from containers as it's not needed
Byroks added 1 commit 2024-01-08 12:11:46 +01:00
fbbd55c420 #18 Remove ContainerId from containers 
Changes
 + remove containerId variable from containers as it's not needed
Byroks requested review from Le-Frique 2024-01-08 12:11:52 +01:00
Byroks requested review from oskaloq 2024-01-08 12:11:52 +01:00
Byroks requested review from ruebe5w 2024-01-08 12:11:52 +01:00
oskaloq approved these changes 2024-01-15 13:46:00 +01:00
oskaloq left a comment
Member
Copy Link

Jetzt verstehe ich, was Du gemeint hast: Die containerId bei den Containern war dafür gedacht, dass man auch Container selbst in andere Container packen kann (zB Truhe in Haus oder Geldbeutel in Rucksack). Ist aber wohl besser, wenn wir das erst einmal weglassen. Macht die Berechnung von Wert und Lasten vermutlich einfacher ...

Jetzt verstehe ich, was Du gemeint hast: Die containerId bei den Containern war dafür gedacht, dass man auch Container selbst in andere Container packen kann (zB Truhe in Haus oder Geldbeutel in Rucksack). Ist aber wohl besser, wenn wir das erst einmal weglassen. Macht die Berechnung von Wert und Lasten vermutlich einfacher ...
Byroks merged commit b5b75aa2c6 into develop 2024-01-15 14:15:32 +01:00
Byroks deleted branch #18-remove-unnecessary-containerId 2024-01-15 14:15:32 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Le-Frique
ruebe5w
oskaloq
Labels
Clear labels
  
bug

Something is not working

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
regelfehler

Funktionalität stimmt nicht mit Regeln überein

  
wontfix

This won't be fixed

No Label
bug
feature
help wanted
invalid
question
regelfehler
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MidgardVTT-Entwicklung/foundry-vtt-system-midgard5#29
No description provided.
Delete Branch "#18-remove-unnecessary-containerId"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?