Adds skills and how to add them to the sheet

source/module/sheets/M5CharacterSheet.ts

@@ -9,7 +9,7 @@ export default class M5CharacterSheet extends ActorSheet {
 		return mergeObject(super.defaultOptions, {
 			template: "systems/midgard5/templates/sheets/character/main.hbs",
 			width: 600,
-			height: 400,
+			height: 800,
 			classes: ["midgard5", "sheet", "character"],
 			tabs: [{ navSelector: ".sheet-navigation", contentSelector: ".sheet-content", initial: "base_values" }]
 		})
@@ -46,6 +46,20 @@ export default class M5CharacterSheet extends ActorSheet {
 			item.sheet.render(true)
 		})
 
+		html.find(".change-special-combat-skill").on("click", async (event) => {
+			const row = event.target.parentElement.parentElement
+			let skillId = row.dataset["skill"]
+
+			const actor = this.actor as any
+			actor.update({
+				data: {
+					skills: {
+						preferredCombatSkill: skillId
+					}
+				}
+			})
+		})
+
 		html.find(".roll-learned-button").on("click", async (event) => {
 			const row = event.target.parentElement.parentElement
 			let skillId = row.dataset["skill"]
@@ -58,6 +72,24 @@ export default class M5CharacterSheet extends ActorSheet {
 			await item.roll()
 		})
 
+		html.find(".create-skill-button").on("click", async (event) => {
+			const button = event.target
+			const skillType = button.dataset["skilltype"]
+
+			const character = this.actor as M5Character
+			character.createSkill((game as Game).i18n.localize("midgard5.new-skill")).then(skill => {
+				const item = skill as any
+				item.update({
+					data: {
+						fw: 5,
+						attribute: "",
+						skill: "",
+						type: skillType
+					}
+				})
+			})
+		})
+
 		html.find(".roll-general-button").on("click", async (event) => {
 			const row = event.target.parentElement.parentElement
 			let skillName = row.dataset["skill"]
@@ -93,30 +125,89 @@ export default class M5CharacterSheet extends ActorSheet {
 			const data = this.actor.data.data
 			const unlearnedSkill = data.skills.general[skillName] as M5SkillUnlearned
 
-			const itemData = {
-				name: (game as Game).i18n.localize("midgard5." + skillName),
-				type: "skill",
-				data: {
-					fw: unlearnedSkill.initial,
-					attribute: unlearnedSkill.attribute,
-					skill: skillName,
-					type: "general"
-				} as M5SkillLearned
-			}
-
-			this.actor.createEmbeddedDocuments("Item", [itemData]).then(docs => {
-				const item = docs[0]
-				//console.log("createEmbeddedDocuments", item.data)
+			const character = this.actor as M5Character
+			character.createSkill((game as Game).i18n.localize("midgard5." + skillName)).then(skill => {
+				const item = skill as any
+				item.update({
+					data: {
+						fw: unlearnedSkill.initial,
+						attribute: unlearnedSkill.attribute,
+						skill: skillName,
+						type: "general"
+					}
+				})
 			})
 		})
 
 		// Drag & Drop
-		// const dragDropSkill = new DragDrop({
-		// 	dragSelector: ".items-list .item",
-		// 	dropSelector: ".sheet-body",
-		// 	permissions: { dragstart: this._canDragStart.bind(this), drop: this._canDragDrop.bind(this) },
-		// 	callbacks: { dragstart: this._onTransferItemDragStart.bind(this), drop: this._onTransferItemDrop.bind(this) },
-		// })
-		// dragDrop.bind(html[0])
+		const dragDrop = new DragDrop({
+			dragSelector: ".items-list .item",
+			dropSelector: ".sheet-body",
+			permissions: { dragstart: this._canDragStart.bind(this), drop: this._canDragDrop.bind(this) },
+			callbacks: { dragstart: this._onTransferItemDragStart.bind(this), drop: this._onTransferItemDrop.bind(this) },
+		})
+		dragDrop.bind(html[0])
 	}
+
+	_canDragStart(selector) {
+		return this.options.editable && this.actor.isOwner;
+	}
+
+	_canDragDrop(selector) {
+		return true;
+	}
+
+	_onTransferItemDragStart(event) {
+		const li = event.currentTarget
+		$(event.currentTarget).attr("data-item-actorid", this.actor.id)
+		const item = this.actor.items.get(li.dataset.itemId)
+
+		// limit transfer on personal weapons/armour/gear
+		if (["weapon"].includes(item.data.type)) {
+			const dragData = {
+				type: "Transfer",
+				actorId: this.actor.id,
+				data: item.data,
+				tokenId: null
+			}
+
+			if (this.actor.isToken)
+				dragData.tokenId = this.actor.token.id
+
+			event.dataTransfer.setData("text/plain", JSON.stringify(dragData))
+		} else {
+			return false
+		}
+	}
+
+	async _onTransferItemDrop(event) {
+		// Try to extract the data
+		let data = null
+		try {
+			data = JSON.parse(event.dataTransfer.getData("text/plain"))
+			if (data.type !== "Transfer")
+				return false
+		} catch (err) {
+			return false
+		}
+
+		if (!data.data)
+			return false
+
+
+		if (data.actorId === this.actor.id)
+			return false
+
+		try {
+			this.actor.createEmbeddedDocuments("Item", [duplicate(data.data)]) // Create a new Item
+			const actor = (game as any).actors.get(data.actorId)
+			await actor.items.get(data.data._id)?.delete() // Delete originating item from other actor
+		} catch (e) {
+			console.error("Error transfering item between actors", e)
+			return false
+		}
+
+		return true
+	}
+	
 }

source/module/sheets/M5ItemSheet.ts

@@ -1,10 +1,11 @@
+import { M5Item } from "../items/M5Item"
 
 export class M5ItemSheet extends ItemSheet {
 	
 	static get defaultOptions() {
 		return mergeObject(super.defaultOptions, {
-			width: 530,
-			height: 340,
+			width: 420,
+			height: 240,
 			classes: ["midgard5", "sheet", "item"]
 		})
 	}
@@ -16,7 +17,9 @@ export class M5ItemSheet extends ItemSheet {
 	}
 
 	override getData(options?: Partial<ItemSheet.Options>): ItemSheet.Data<ItemSheet.Options> | Promise<ItemSheet.Data<ItemSheet.Options>> {
+		const item = this.item as M5Item
 		return Promise.resolve(super.getData()).then(value => {
+			item.prepareDerivedData()
 			const context = value as any
 
 			// Use a safe clone of the item data for further operations.