MidgardVTT-Entwicklung/foundry-vtt-system-midgard5
7
0
Fork 0
Code Issues 16 Pull Requests Actions Projects 1 Releases 8 Wiki Activity

#33 Wrong wealth calculation #34

Merged
Byroks merged 3 commits from #33-wrong-wealth-calculation into develop 2024-01-16 08:29:16 +01:00
Conversation 2 Commits 3 Files Changed 1
+18 -5
Byroks commented 2024-01-08 13:54:49 +01:00
Owner
Copy Link
Copy Source

Changes:

  • add function to adjust item value depending on currency
Changes: + add function to adjust item value depending on currency
Byroks added 1 commit 2024-01-08 13:54:50 +01:00
#33 Wrong wealth calculation a5c5b6c9e7 
Changes:
 + add function to adjust item value depending on currency
Byroks requested review from Le-Frique 2024-01-08 13:54:54 +01:00
Byroks requested review from oskaloq 2024-01-08 13:54:54 +01:00
Byroks requested review from ruebe5w 2024-01-08 13:54:55 +01:00
oskaloq commented 2024-01-15 13:30:35 +01:00
Member
Copy Link
Copy Source

Grundsätzlich funktioniert es hervorragend, aber wenn man Dezimalzahlen (z.B. 1,5 GS) bei einem der Items einträgt, rechnet das System auch nach Änderung in natürliche Zahlen mit vielen Nachkommastellen.
image

Grundsätzlich funktioniert es hervorragend, aber wenn man Dezimalzahlen (z.B. 1,5 GS) bei einem der Items einträgt, rechnet das System auch nach Änderung in natürliche Zahlen mit vielen Nachkommastellen. ![image](/attachments/56780bbd-3595-4d6b-94f6-58edbf45485e)
image.png
467 KiB
Byroks added 1 commit 2024-01-15 14:39:02 +01:00
Merge branch 'develop' into #33-wrong-wealth-calculation f61e088238
Byroks added 1 commit 2024-01-15 15:35:08 +01:00
Floating rounding error f3f13fa2f9 
Changes:
 + add precision
oskaloq approved these changes 2024-01-15 21:56:35 +01:00
oskaloq left a comment
Member
Copy Link
Copy Source

Tests with different variants successfull

Tests with different variants successfull
Byroks merged commit abf8077131 into develop 2024-01-16 08:29:16 +01:00
Byroks deleted branch #33-wrong-wealth-calculation 2024-01-16 08:29:17 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Le-Frique
ruebe5w
oskaloq
Labels
Clear labels
bug
Something is not working
 feature
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 regelfehler
Funktionalität stimmt nicht mit Regeln überein
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Byroks Le-Frique Masek0815 korstefan14 oskaloq ruebe5w veilza
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MidgardVTT-Entwicklung/foundry-vtt-system-midgard5#34