MidgardVTT-Entwicklung
/
foundry-vtt-system-midgard5
7
0
Fork 0
Code Issues 16 Pull Requests Actions Projects 1 Releases 8 Wiki Activity

#33 Wrong wealth calculation #34

Merged
Byroks merged 3 commits from #33-wrong-wealth-calculation into develop 2024-01-16 08:29:16 +01:00
Conversation 1 Commits 3 Files Changed 1 +18 -5
Byroks commented 2024-01-08 13:54:49 +01:00
Owner
Copy Link

Changes:

  • add function to adjust item value depending on currency
Changes: + add function to adjust item value depending on currency
Byroks added 1 commit 2024-01-08 13:54:50 +01:00
a5c5b6c9e7 #33 Wrong wealth calculation 
Changes:
 + add function to adjust item value depending on currency
Byroks requested review from Le-Frique 2024-01-08 13:54:54 +01:00
Byroks requested review from oskaloq 2024-01-08 13:54:54 +01:00
Byroks requested review from ruebe5w 2024-01-08 13:54:55 +01:00
oskaloq commented 2024-01-15 13:30:35 +01:00
Member
Copy Link

Grundsätzlich funktioniert es hervorragend, aber wenn man Dezimalzahlen (z.B. 1,5 GS) bei einem der Items einträgt, rechnet das System auch nach Änderung in natürliche Zahlen mit vielen Nachkommastellen.
image

Grundsätzlich funktioniert es hervorragend, aber wenn man Dezimalzahlen (z.B. 1,5 GS) bei einem der Items einträgt, rechnet das System auch nach Änderung in natürliche Zahlen mit vielen Nachkommastellen. ![image](/attachments/56780bbd-3595-4d6b-94f6-58edbf45485e)
image.png
467 KiB
Byroks added 1 commit 2024-01-15 14:39:02 +01:00
Byroks added 1 commit 2024-01-15 15:35:08 +01:00
f3f13fa2f9 Floating rounding error 
Changes:
 + add precision
oskaloq approved these changes 2024-01-15 21:56:35 +01:00
oskaloq left a comment
Member
Copy Link

Tests with different variants successfull

Tests with different variants successfull
Byroks merged commit abf8077131 into develop 2024-01-16 08:29:16 +01:00
Byroks deleted branch #33-wrong-wealth-calculation 2024-01-16 08:29:17 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Le-Frique
ruebe5w
oskaloq
Labels
Clear labels
  
bug

Something is not working

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
regelfehler

Funktionalität stimmt nicht mit Regeln überein

  
wontfix

This won't be fixed

No Label
bug
feature
help wanted
invalid
question
regelfehler
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MidgardVTT-Entwicklung/foundry-vtt-system-midgard5#34
No description provided.
Delete Branch "#33-wrong-wealth-calculation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?